feat(EXC-1795): Limit cache disk space #3366
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EXC-1795 Add the ability for the LRU cache to limit space used on disk as well as in memory and use this in the `CompilationCache` so that it doesn't grow to large.
|
Old comment: #3348 (comment) |
|
Old comment: #3348 (comment) |
| @@ -39,7 +39,7 @@ pub enum CompilationCache { | |||
| impl CompilationCache { | |||
| pub fn new(capacity: NumBytes) -> Self { | |||
| Self::Memory { | |||
| cache: Mutex::new(LruCache::new(capacity)), | |||
| cache: Mutex::new(LruCache::new(capacity, NumBytes::from(1024 * 1024 * 1024))), | |||
There was a problem hiding this comment.
nit: maybe add a config/constant instead of multiplying 1024*1024*1024 to define 1 GiB?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EXC-1795
Add the ability for the LRU cache to limit space used on disk as well as in memory and use this in the
CompilationCacheso that it doesn't grow to large.