feat: range requests for certified assets #199
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lastmjs
changed the title
lastmjs
changed the title
lastmjs
changed the title
|
I'm not sure how to move forward after this conversation: https://forum.dfinity.org/t/boundary-node-http-response-headers/10747/6 If the ETA on boundary nodes serving partial responses is far into the future, then I'm wondering if we can get this PR merged in the mean time, or if I should just maintain a fork for those interested in the functionality until the more scalable and robust boundary node version is deployed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original issue, not sure if I should move it to this repo: dfinity/certified-assets#10
This was originally pull-requested here: dfinity/certified-assets#21
I'm still cleaning up a bit and doing some testing, but I would love to get feedback. Besides minor cleanup and some possibly optional features missing as described here dfinity/certified-assets#10, I am done with the implementation of range requests.