Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add encoding functions for external signing #600

Merged
merged 1 commit into from
Sep 27, 2024
Merged

feat: Add encoding functions for external signing #600

merged 1 commit into from
Sep 27, 2024

Conversation

adamspofford-dfinity
Copy link
Contributor

This PR adds two missing functions to close the loop around non-Identity forms of signing - the ability to construct EnvelopeContent using the agent's autofill logic, and the ability to encode Envelope to the format expected by update_signed.

@adamspofford-dfinity adamspofford-dfinity marked this pull request as ready for review September 27, 2024 18:01
@adamspofford-dfinity adamspofford-dfinity requested a review from a team as a code owner September 27, 2024 18:01
@adamspofford-dfinity adamspofford-dfinity merged commit 7a109b9 into main Sep 27, 2024
24 checks passed
@adamspofford-dfinity adamspofford-dfinity deleted the spofford/encode-signed branch September 27, 2024 22:29
adamspofford-dfinity added a commit that referenced this pull request Nov 25, 2024
@adamspofford-dfinity
feat: Add encoding functions for external signing (#600)
81ac55e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericswanson-dfinity ericswanson-dfinity ericswanson-dfinity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamspofford-dfinity @ericswanson-dfinity