Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use setup-dfx github action #519

Closed
wants to merge 2 commits into from
Closed

Conversation

ericswanson-dfinity
Copy link
Member

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.

Fixes # (issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@ericswanson-dfinity ericswanson-dfinity requested a review from a team as a code owner February 21, 2024 20:51
@@ -24,16 +24,16 @@ jobs:
target
key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }}-1

- name: Setup fix
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: Setup fix
- name: Setup dfx

@lwshang
Copy link
Contributor

lwshang commented Feb 21, 2024

Just realized that e2e.yml doesn't really run any tests.

      # - name: 'Run tests'
      #   run: bats e2e/bash/icx.bash 

Maybe we can delete it?
Or we fix icx.bash and enable the test?

@ericswanson-dfinity
Copy link
Member Author

Duplicates #518

@ericswanson-dfinity ericswanson-dfinity deleted the dfxvm-ci branch May 6, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants