Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: change type of skip_pre_upgrade #516

Merged
merged 1 commit into from
Feb 20, 2024
Merged

fix!: change type of skip_pre_upgrade #516

merged 1 commit into from
Feb 20, 2024

Conversation

sesi200
Copy link
Contributor

@sesi200 sesi200 commented Feb 20, 2024

Description

Tried to add --skip-pre-upgrade to dfx and noticed it doesn't work. Turns out the type is wrong

How Has This Been Tested?

Not tested.

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@sesi200 sesi200 requested a review from a team as a code owner February 20, 2024 10:08
@sesi200 sesi200 merged commit f5ce76b into main Feb 20, 2024
24 checks passed
@sesi200 sesi200 deleted the severin/fix-skip-pre-upgrade-type branch February 20, 2024 14:41
@q2333gh q2333gh mentioned this pull request Feb 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericswanson-dfinity ericswanson-dfinity ericswanson-dfinity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sesi200 @ericswanson-dfinity