Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pre signed read state call wait #511

Merged
merged 7 commits into from
Feb 7, 2024

Conversation

NikolasHaimerl
Copy link
Contributor

This MR proposes the following changes:

Currently, the agent can only be used with a private key that is known to the agent. If someone wants to sign their request outside of the agent, they cannot forward this signed request using the agent.

The agent already offers a method that lets a user forward a signed Envelope of EnvelopeContent::Call to the IC. This MR adds the same functionality for a signed Envelope of EnvelopeContent::ReadState to the IC.

The method that is added is similar to the already existing wait(..) method but also takes in the signed request.

@NikolasHaimerl NikolasHaimerl requested a review from a team as a code owner February 6, 2024 21:06
@NikolasHaimerl NikolasHaimerl changed the title Draft: add pre signed read state call wait Draft: feat: add pre signed read state call wait Feb 6, 2024
@NikolasHaimerl NikolasHaimerl changed the title Draft: feat: add pre signed read state call wait feat: add pre signed read state call wait Feb 6, 2024
Copy link
Contributor

@adamspofford-dfinity adamspofford-dfinity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamspofford-dfinity adamspofford-dfinity merged commit 6330d29 into dfinity:main Feb 7, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants