Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly use local git repo dependencies cache #2709

Merged
merged 1 commit into from
Sep 5, 2023
Merged

fix: correctly use local git repo dependencies cache #2709

merged 1 commit into from
Sep 5, 2023

Conversation

Andrioden
Copy link
Contributor

@Andrioden Andrioden commented Sep 4, 2023

What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix

What does this pull request do? Which issues does it resolve? (use resolves #<issue_number> if possible)
resolves #2641

Please provide a short message that should be published in the DevSpace release notes
Fixed an issue where DevSpace deploy did not correctly use the C:\Users\[user]\.devspace\dependencies cached files, ending up always pulling the git repo.

What else do we need to know?

  • Not able to write tests for this as the test scripts dont work on windows.
  • Tested locally by building devspace.exe and calling C:\Projects\devspace-deps-fix\devspace.exe deploy --debug

@netlify
Copy link

netlify bot commented Sep 4, 2023

Deploy Preview for devspace-docs canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 446cf89
🔍 Latest deploy log https://app.netlify.com/sites/devspace-docs/deploys/64f64f0f3d385c0008eb261f

Copy link
Collaborator

@lizardruss lizardruss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge after tests run.

@lizardruss lizardruss merged commit fe6d264 into devspace-sh:main Sep 5, 2023
18 checks passed
@Andrioden Andrioden deleted the local-files-dep branch September 5, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improving performance of dependency git pulling
2 participants