fix: --dependency flag is respected by dependency resolving #2708
Conversation
✅ Deploy Preview for devspace-docs canceled.Built without sensitive environment variables
|
Andrioden
changed the title
pkg/devspace/dependency/manager.go
Outdated
| @@ -39,7 +40,7 @@ func NewManagerWithParser(ctx devspacecontext.Context, configOptions *loader.Con | |||
|
|
|||
| type ResolveOptions struct { | |||
| SkipDependencies []string | |||
| Dependencies []string | |||
| Dependencies []string // Same as DependencyOptions.Only, either should be renamed | |||
There was a problem hiding this comment.
The devspace deploy --dependency flag should be renamed --only, but thats beyond this pr and not backwards compatible. So i added this comment for clarity.
Resolve when comment is read.
There was a problem hiding this comment.
I don't think the flags will be renamed. As you mentioned, there's backwards compatibility to consider, but also changing the global flags may make them ambiguous. The BuildOptions() function handles mapping the global flag to the more specific run_dependency_pipelines function options.
Otherwise the changes look good! Thank you so much!
There was a problem hiding this comment.
Comment removed, need workflow approval (i think? not that familiar with these GitHub gates)
pkg/devspace/dependency/manager.go
Outdated
| @@ -39,7 +40,7 @@ func NewManagerWithParser(ctx devspacecontext.Context, configOptions *loader.Con | |||
|
|
|||
| type ResolveOptions struct { | |||
| SkipDependencies []string | |||
| Dependencies []string | |||
| Dependencies []string // Same as DependencyOptions.Only, either should be renamed | |||
There was a problem hiding this comment.
I don't think the flags will be renamed. As you mentioned, there's backwards compatibility to consider, but also changing the global flags may make them ambiguous. The BuildOptions() function handles mapping the global flag to the more specific run_dependency_pipelines function options.
Otherwise the changes look good! Thank you so much!
Signed-off-by: André S. Hansen <[email protected]>
Signed-off-by: André S. Hansen <[email protected]>
What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)Partly solves #2641
Please provide a short message that should be published in the DevSpace release notes
Fixed an issue where DevSpace flag --dependency was not respected by the git repo recursive resolver
What else do we need to know?
I have not ran any unit tests or e2e tests as your contribution guide and bash scripts dont work on windows.
I have tested manually by building a devspace.exe file and then tested these 3 cases standing in a repo with a complex dependency hierarchy:
1 - Normal
C:\Projects\devspace-deps-fix\devspace.exe deploy --debug-> Download all repos and deploy all
2 - Filter away all
C:\Projects\devspace-deps-fix\devspace.exe deploy --dependency "-" --debug-> Download no repos, and deploy only self
3 - Filter to one dependency
C:\Projects\devspace-deps-fix\devspace.exe deploy --dependency "hn-oppsett" --debug-> Download dependency, and deploy it and self