Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cosmetic changes #2212

Open
wants to merge 3 commits into
base: add-en-links
Choose a base branch
from

Conversation

gf-mse
Copy link
Contributor

@gf-mse gf-mse commented Sep 21, 2019

I am no expert here, so these are mere suggestions:

  1. I propose to capitalize "Position, Company" in accordance with Title Capitalization
  1. Next, I suggest to add a reference to GitHub standard workflow
  • motivation: while an ability to use a source control repository is arguably an inherent qualification for an IT professional, one shall not expect each and every one to use this particular system (Git) in their daily practice ; therefore, a simple HOWTO reference seems appropriate. OTOH, an ability to easily pick such a reference is expected.
  1. Finally, there is some minor re-wording of the last sentences. In my opinion, this is the most arguable part -- I was basically trying to soften the sentences according to my understanding.

  2. One final thing which is not here -- @nazarov-tech has a good point in 1147 referring to Falsehoods Programmers Believe About Names : in the global world, the names are indeed quite a complex story ( and, for one thing, a person still can have no surname at all ). As for the order of the names ( First Name Last Name, or Last Name, First Name ) -- please don't even get me started 😂

So I would rather re-word the instruction at the end in the following manner:

  • give a hint that this is not the one and only possible format for a signature, but merely the recommended way -- may be we shall put there something like Names | About ?
  • add a link to the source code to serve as an ultimate reference for the signature file specification.

NB: edits from maintainers are allowed in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants