Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vagrant-libvirt: update installation instructions #454

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

msehnout
Copy link
Contributor

Following the tutorial on Vagrant libvirt, I wasn't able to run it. I found this thread on ask fedora: https://ask.fedoraproject.org/t/vagrant-up-not-working-what-did-i-forget/20094/10 It suggested to enable virtnetworkd and install the virtualization group.

It might be beneficial to have it in the developer portal directly to avoid future confusion.

Following the tutorial on Vagrant libvirt, I wasn't able to run it. I found this thread on ask fedora:
https://ask.fedoraproject.org/t/vagrant-up-not-working-what-did-i-forget/20094/10
It suggested to enable virtnetworkd and install the virtualization group.

It might be beneficial to have it in the developer portal directly to avoid future confusion.
@jackorp jackorp self-assigned this Sep 23, 2022
Copy link
Contributor

@jackorp jackorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the patch. This seems to be required because Fedora changed the layout of libvirt services: https://fedoraproject.org/wiki/Changes/LibvirtModularDaemons .

Since it seems that enabling virtnetworkd is indeed required, let's update also the previous step for the modular libvirt services present with F35+.

Additionally, I do not think we need the virtualization group explicitly, installing just vagrant-libvirt (or vagrant-libvirt with @vagrant) brings in all that is needed. I have tested this in a fresh VM. If that approach does not work, then there is a bug with the requirements of @vagrant IMO


```
$ sudo systemctl enable libvirtd
$ sudo systemctl enable --now libvirtd
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$ sudo systemctl enable --now libvirtd
$ sudo systemctl enable --now virtqemud


```
$ sudo dnf install vagrant-libvirt
$ sudo dnf group install virtualization
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think this is needed. vagrant-libvirt should pull in all that is required.

@@ -6,10 +6,11 @@ order: 2

# Vagrant with libvirt support installation

To use Vagrant with libvirt, you need to install the `vagrant-libvirt` package:
To use Vagrant with libvirt, you need to install the `vagrant-libvirt` package and the `virtualization` group:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To use Vagrant with libvirt, you need to install the `vagrant-libvirt` package and the `virtualization` group:
To use Vagrant with libvirt, you need to install the `vagrant-libvirt` package:

@@ -18,10 +19,11 @@ There is also *@vagrant* package collection created with libvirt provider in min
$ sudo dnf install @vagrant
```

Afterwards make sure that libvirt daemon is running and that you have `kvm` module loaded in the kernel:
Afterwards make sure that libvirt and virtnetworkd daemons are running and that you have `kvm` module loaded in the kernel:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From how packaged libvirt daemons are right now in Fedora, the maintainer insists reboot is needed for everything to work properly.

@pvalena
Copy link
Contributor

pvalena commented Oct 3, 2022

Following the tutorial on Vagrant libvirt, I wasn't able to run it. I found this thread on ask fedora: https://ask.fedoraproject.org/t/vagrant-up-not-working-what-did-i-forget/20094/10 It suggested to enable virtnetworkd and install the virtualization group.

It might be beneficial to have it in the developer portal directly to avoid future confusion.

@msehnout can you verify the proposed changes please?

@pvalena pvalena mentioned this pull request Oct 12, 2022
@msehnout
Copy link
Contributor Author

I'm sorry, I forgot about this PR. Can we close it now that you are incorporating it into your own MR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants