Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pygobject3-devel to pygobject installation instructions #363

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

jkotra
Copy link

@jkotra jkotra commented Jan 17, 2021

No description provided.

@pvalena
Copy link
Contributor

pvalena commented Jan 17, 2021

Why?

@jkotra
Copy link
Author

jkotra commented Jan 17, 2021

This package seems to be needed for building most python gtk applications.

Meson will complain when it encounters
dependency('pygobject-3.0', version: '>= 3.29.1')

@pvalena
Copy link
Contributor

pvalena commented Jan 18, 2021

I'm not sure, as I'm not familiar with the process... maybe it should be just a suggestion?

@hroncok PTAL.

@hroncok
Copy link
Collaborator

hroncok commented Jan 18, 2021

@hroncok PTAL.

I am not much familiar with pygobject, sorry.

@pvalena
Copy link
Contributor

pvalena commented Jan 19, 2021

In that case, I'm fine with it, but please explain what it's for in the text above the command.

@@ -13,7 +13,7 @@ PyGObject provides full support of GObject Introspection and all of its features
To install PyGObject on Fedora, run:

```
$ sudo dnf install python3-gobject
$ sudo dnf install python3-gobject pygobject3-devel
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$ sudo dnf install python3-gobject pygobject3-devel
$ sudo dnf install python3-gobject pygobject3-devel
# `pygobject3-devel` seems to be needed for building most python gtk applications

@pvalena
Copy link
Contributor

pvalena commented May 31, 2021

ping: #363 (comment)

@pvalena pvalena self-assigned this Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants