Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Level output #4

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Level output #4

wants to merge 9 commits into from

Conversation

paulfd
Copy link
Contributor

@paulfd paulfd commented Jul 29, 2020

(Builds up from #3)

This adds a level output that is monitored by the mod UI. The threshold value is set to track from this level, so you can adapt it to the signal somehow.

@devcurmudgeon
Copy link
Owner

Hi @paulfd thank you for this PR - i think the idea is interesting but it's made me wonder about making some more fundamental improvements to the UI. The realtime numeric value looks a bit untidy - ideally there would be a moving level signal or maybe just a light going on when the threshold is hit?

Also several users have asked for different colours for the loop buttons to distinguish between recording and playing.

I'm not sure how soon I'll get around to this, though, so if you're feeling inspired please feel free :-)

thanks again

@paulfd
Copy link
Contributor Author

paulfd commented Sep 6, 2020

The light is a good idea !

If I find some time I'll definitely look around it. I'm a bit slow, front-end things like this are not really my forte :D

@devcurmudgeon
Copy link
Owner

No problem - I struggle with UX too. But notice the click is now a first-class citizen, with its own knob and everything :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants