Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix to help tests for powershell 74 #42

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gazm81
Copy link
Contributor

@gazm81 gazm81 commented Feb 1, 2024

Description

as mentioned in the issue,
powershell 7.4 broke help.tsts.ps1

Related Issue

related issue #41

Motivation and Context

as mentioned in the issue,
powershell 7.4 broke help.tsts.ps1
this is to rectify that issue for the stucco repo AND the template

How Has This Been Tested?

tests on development machine using variety of powershell versions
test using devcontainer pinned with different versions including powershell 7.2 7.3 7.4
and os options of ubuntu 20.04 and 22.04
additionally on windows 11 environment

Screenshots (if appropriate):

NA - issue contains

Types of changes

  • [ X] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [ X] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [ X] I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • [ X] All new and existing tests passed.

@dlathrop
Copy link

I tried applying this patch on local copy of the project.
It fixed the failed Pester tests.
Project build modified the Get-StuccoTemplate.md and New-StuccoModule.md to show " [-ProgressAction ]" as a parameter. I don't know if this is an intended result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants