Update computation of expiration block height #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 12, 2024
Merged
Closed
Closed
Closed
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merged
lazynina
force-pushed
the
update-expiration-block-height-computation
branch
from
bae00ad
to
d5b5680
Compare
| // days * (24 hours / day) * (60 minutes / hour) * (1 block / 5 minutes) = blocks | ||
| const numBlocksBeforeExpiration = (numDaysBeforeExpiration * 24 * 60) / 5; | ||
| // days * (24 hours / day) * (60 minutes / hour) * (60 seconds / minute) * (1 block / second) = blocks | ||
| const numBlocksBeforeExpiration = numDaysBeforeExpiration * 24 * 60 * 60; |
There was a problem hiding this comment.
Ah, love to see this. 1 second confirmations!!!!
Base automatically changed from
pos-spending-limits
to
feature/proof-of-stake
February 13, 2024 14:26
lazynina
added a commit
that referenced
this pull request
Apr 30, 2024
* PoS Spending Limits UI * Update computation of expiration block height
lazynina
added a commit
that referenced
this pull request
Apr 30, 2024
* PoS Spending Limits UI * Update computation of expiration block height
lazynina
added a commit
that referenced
this pull request
Jun 17, 2024
* Add newline to make graphite happy * Lockups (#299) * Add transcoder for Register as validator transaction. Add support for approve component for this txn type * Add transcoder for Unregister as validator txn type. Add support for approve component for this new txn type * Add transcoder for stake transaction metadata. Add support for approve component for this new txn type. * Add transcoder for Unstake txn type. Add support for approve component for this new txn type. * Add transcoder for Unlock stake txn type. Add support for approve UI for this new txn type * Add transcoder for Unjail Validator txn type. Add approve UI support for this new txn type. * Add support for coin lockup txn types --------- Co-authored-by: Lazy Nina <> * PoS Spending Limits UI (#298) * Update computation of expiration block height (#300) * PoS Spending Limits UI * Update computation of expiration block height --------- Co-authored-by: Lazy Nina <> Co-authored-by: Jon Pollock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.