fix: fix broken avatar directive

deso-protocol · Sep 21, 2023 · 6384f1b · 6384f1b
1 parent 8d0c9d4
commit 6384f1b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 10 deletions.
diff --git a/src/app/avatar/avatar.directive.ts b/src/app/avatar/avatar.directive.ts
@@ -3,6 +3,8 @@ import _ from 'lodash';
 import { BackendAPIService } from '../backend-api.service';
 import { GlobalVarsService } from '../global-vars.service';
 
+const DEFAULT_PROFILE_PIC_URL = window.location.origin + '/assets/placeholder-account-image.png';
+
 @Directive({
   selector: '[appAvatar]',
 })
@@ -22,19 +24,18 @@ export class AvatarDirective implements OnChanges {
 
     if (!this.appAvatar) {
       this.setURLOnElement(
-        this.backendApi.GetDefaultProfilePictureURL(window.location.host)
+        DEFAULT_PROFILE_PIC_URL
       );
       return;
     }
-    // The fallback route is the route to the pic we use if we can't find an avatar for the user.
-    const fallbackRoute = `fallback=${this.backendApi.GetDefaultProfilePictureURL(
-      window.location.host
-    )}`;
 
     // Although it would be hard for an attacker to inject a malformed public key into the app,
     // we do a basic _.escape anyways just to be extra safe.
     const profPicURL = _.escape(
-      this.backendApi.GetSingleProfilePictureURL(this.appAvatar, fallbackRoute)
+      this.backendApi.GetSingleProfilePictureURL(
+        this.appAvatar,
+        DEFAULT_PROFILE_PIC_URL
+      )
     );
 
     // Set the URL on the element.

diff --git a/src/app/backend-api.service.ts b/src/app/backend-api.service.ts
@@ -385,10 +385,6 @@ export class BackendAPIService {
     )}/${PublicKeyBase58Check}?fallback=${FallbackURL}`;
   }
 
-  GetDefaultProfilePictureURL(defaultImgHost: string): string {
-    return defaultImgHost + '/assets/img/default_profile_pic.png';
-  }
-
   JumioBegin(
     PublicKey: string,
     ReferralHashBase58: string,