Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add $CLOUT tooltips to CC holdings/price on wallet page #427

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

netpro2k
Copy link

With recent price volatility it has been hard to tell what is happening to the value of CC holdings. It would be nice to be able to see values in $CLOUT instead of USD.

This PR adds a simple system tooltip (title attribute) to the wallet total, CC price, and CC cashout values to show the equivalent values in $CLOUT.

clout-tooltip

Ultimately this is something that should probably happen site wide anywhere a price is displayed (along with the ability to change the default denomination to $CLOUT or BTC) but that is a much bigger change and probably involves some design decisions.

This is the lowest effort, highest impact, version of that.

@netpro2k netpro2k requested a review from a team as a code owner August 27, 2021 05:01
@ItsAditya-xyz
Copy link
Contributor

great work @netpro2k ! do you think if we can display it instead of hover event ?

@netpro2k
Copy link
Author

netpro2k commented Aug 29, 2021

great work @netpro2k ! do you think if we can display it instead of hover event ?

Yep I do think there are better solutions to this with some further design changes but that would probably require some more back and forth. This feels obviously better than what we have now without having to really sacrifice anything. I think a site wide solution to this should be figured out, but that's a bigger discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants