Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Emoji Picker for Posts #197

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

metaspartan
Copy link
Contributor

This adds in a new Emoji icon next to embeds and images for posting, which brings up a nice selector to select an emoji, it can go off system themes only (light or dark) but we could expand this eventually...Seems to work great on mobile as well, this uses unicode emojis so they fit right into your current message.

This does have a new dependency required npm install @joeattardi/emoji-button so you will need to do a fresh npm install of the frontend for this to work, otherwise should be good to go @lazynina @maebeam @diamondhands0

Preview:
0JtjRoQYEL

@metaspartan metaspartan requested a review from a team as a code owner June 19, 2021 23:32
Copy link
Member

@lazynina lazynina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See feedback comments please. Also, this may take a while as there are dependencies to be audited for vulnerabilities.

src/styles.scss Outdated Show resolved Hide resolved
@lazynina
Copy link
Member

@carsenk I suggested some changes that should apply the selected theme to the emoji picker. This is an example of what it looks like on legends theme with the suggested changes

image

@metaspartan
Copy link
Contributor Author

@carsenk I suggested some changes that should apply the selected theme to the emoji picker. This is an example of what it looks like on legends theme with the suggested changes

image

Pushed changes up, works across themes! 🚀🤘

add styling for overlay and focus
@lazynina lazynina self-requested a review June 21, 2021 05:02
Copy link
Member

@lazynina lazynina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maebeam for 2nd review. I looked through the dependencies of the emoji-button lib and they appear to be well-maintained and safe from my review.

@maebeam
Copy link
Contributor

maebeam commented Jun 21, 2021

While this PR looks great, our package-lock.json file is currently frozen until we implement LavaMoat to protect against dependency tree compromises.

@metaspartan
Copy link
Contributor Author

metaspartan commented Jun 21, 2021

While this PR looks great, our package-lock.json file is currently frozen until we implement LavaMoat to protect against dependency tree compromises.

How do you want us to proceed? package-lock.json should be in gitignore?

A suggestion would be to fork all deps into bitclouts own repos and then link the package.json to those, requiring approval for upstream changes, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants