-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Emoji Picker for Posts #197
base: main
Are you sure you want to change the base?
Conversation
…epending on theme selection
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See feedback comments please. Also, this may take a while as there are dependencies to be audited for vulnerabilities.
@carsenk I suggested some changes that should apply the selected theme to the emoji picker. This is an example of what it looks like on legends theme with the suggested changes |
Pushed changes up, works across themes! 🚀🤘 |
add styling for overlay and focus
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maebeam for 2nd review. I looked through the dependencies of the emoji-button lib and they appear to be well-maintained and safe from my review.
While this PR looks great, our |
How do you want us to proceed? package-lock.json should be in gitignore? A suggestion would be to fork all deps into bitclouts own repos and then link the package.json to those, requiring approval for upstream changes, etc. |
This adds in a new Emoji icon next to embeds and images for posting, which brings up a nice selector to select an emoji, it can go off system themes only (light or dark) but we could expand this eventually...Seems to work great on mobile as well, this uses unicode emojis so they fit right into your current message.
This does have a new dependency required
npm install @joeattardi/emoji-button
so you will need to do a fresh npm install of the frontend for this to work, otherwise should be good to go @lazynina @maebeam @diamondhands0Preview: