Optimize AddBlock logic for pos fee estimator #1218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
lazynina
force-pushed
the
optimize-pos-fee-estimator-add-block
branch
3 times, most recently
from
20b95c6
to
e870bae
Compare
lazynina
force-pushed
the
optimize-pos-fee-estimator-add-block
branch
from
e870bae
to
94695d3
Compare
tholonious
reviewed
Apr 13, 2024
|
|
||
| // Remove all blocks that were pruned are no longer in the cached blocks. | ||
| for _, removedBlock := range removedBlocks { | ||
| if err = posFeeEstimator.removeBlockNoLock(removedBlock); err != nil { |
There was a problem hiding this comment.
This operation ends up reinitializing the transaction register for every block that's removed. I think it ends up being even less efficient than the original code
There was a problem hiding this comment.
removeBlockNoLock was updated to modify the transaction register in place w/o creating a new one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.