New endpoint for enabling video download of Cloudfare videos #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cloudflare does NOT allow uploaded videos to be downloaded (just streamed).
This is enough for frontend apps (like Diamond or Desofy) but not for backend apps (like OneClout) which need to download the video to their servers before uploading it to a different platform (e.g. Twitter).
Cloudflare includes an endpoint that enables an uploaded video to be downloaded.
This PR adds a DeSo endpoint that calls said Cloudfare endpoint for a given video identifier.
It's important to note that a Cloudflare download is billed in the same way as the streaming of the video, which means that DeSo nodes will NOT be charged extra if this endpoint is used.
Note: I've created a new PR on the docs repo for the corresponding API documentation for when/if this PR is merged.