Fix 2 issues: (1) buffer that we switched to remains unlisted; (2) problem with symlink buffers #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l edit." This reverts commit 8a8fa09. The problem that it is supposed to address ("the cursor always returns at the beginning of the file") is not specific to fswitch and can be fixed by an autocommand in a more generic way (autocmd BufWinEnter * exe "normal! g`\""). On the other hand, this commit introduces two problems: - when switching to an unlisted buffer, it remains unlisted. This leads, for example, to counterintuitive behavior in buftabline (and probably other similar plugins): currently opened buffer is not in buffer list. - problem with opening symlink buffers (derekwyatt#11) Reverting it solves both.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 8a8fa09 ("Switch buffer if file is already opened instead of always call edit.")
The problem that it is supposed to address ("the cursor always returns
at the beginning of the file") is not specific to fswitch and can be
fixed by an autocommand in a more generic way (
autocmd BufWinEnter * exe "normal! g""`).On the other hand, this commit introduces two problems:
leads, for example, to counterintuitive behavior in buftabline (and
probably other similar plugins): currently opened buffer is not
in buffer list.
Reverting it solves both.