Support Rails 7.1.2 #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`internal_exec_query`: https://github.com/rails/rails/pull/48188/files `raw_execute`: rails/rails@63c0d6b Implementations for these are just copied from the MySQL2 adapter. For `reconnect`, only a stub is present because retries make less sense when offloading to PTOSC
The signature of Migrator has changed again, and does not seem friendly to external usage. Standardization on MigrationContext fixes the missing method issue.
Ref: departurerb#92 Co-authored-by: Katie Edgar <[email protected]>
|
I updated the target Ruby version to support https://github.com/departurerb/departure/pull/93/files#diff-bc2049c1721297c73775182ffa5184cc75a4da11beea53183cb354db6f8af502R93 which triggered issues in a lot of other files (including some not updated in this PR). Personally, it seems like a good idea to keep the target version equal to the oldest version this library supports, but I can alter the code to avoid |
benlangfeld
reviewed
Jan 1, 2024
Co-authored-by: Brian Austin <[email protected]>
xjunior
approved these changes
Jan 2, 2024
benlangfeld
approved these changes
Jan 2, 2024
This was referenced Jan 2, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new methods to the Percona adapter required by a few changes in Rails 7.1:
raw_execute: Active Record: clear query cache automatically when calling#executerails/rails#48061 reused the implementations from the MySQL2 adapter, but I can add any required customisations.internal_exec_query: Revert "Merge pull request #48069 from Shopify/ar-exec-query-flush-cache rails/rails#48188 implementation fromexec_queryreconnect: I only added a stub because retries that way make less sense when offloading to PTOSCOn the tests front, I replaced
ActiveRecord::MigratorwithActiveRecord::MigrationContextto solve method missing issues.Gemspec/CI changes from #92