Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid double definition of shared examples #104

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Avoid double definition of shared examples #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion spec/lhm/adapter/add_column_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
require 'spec_helper'
require 'lhm/adapter/shared_example_column_definition_method_spec'

describe Lhm::Adapter, '#add_column' do
it_behaves_like 'column-definition method', :add_column
Expand Down
1 change: 0 additions & 1 deletion spec/lhm/adapter/change_column_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
require 'spec_helper'
require 'lhm/adapter/shared_example_column_definition_method_spec'

describe Lhm::Adapter, '#change_column' do
it_behaves_like 'column-definition method', :change_column
Expand Down
1 change: 1 addition & 0 deletions spec/spec_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
require 'support/matchers/have_column'
require 'support/matchers/have_index'
require 'support/matchers/have_foreign_key_on'
require 'support/shared_examples/column_definition_method'
require 'support/table_methods'

db_config = Configuration.new
Expand Down
1 change: 0 additions & 1 deletion ..._example_column_definition_method_spec.rb → ...ared_examples/column_definition_method.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
# TODO: What about ENUM?
shared_examples 'column-definition method' do |method_name|
let(:migration) { double(:migration) }
let(:table_name) { :comments }
Expand Down