Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API-43985-standard-data-service-spec #20322

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

stiehlrod
Copy link
Contributor

@stiehlrod stiehlrod commented Jan 16, 2025

Summary

  • Adds spec and cassette for standard data service.

Related issue(s)

What areas of the site does it impact?

new file:   modules/claims_api/spec/lib/claims_api/bgs/standard_data_service_spec.rb
new file:   spec/support/vcr_cassettes/claims_api/bgs/standard_data_service/get_contention_classification_type_code_list.yml

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@stiehlrod stiehlrod self-assigned this Jan 16, 2025
@stiehlrod stiehlrod requested a review from a team as a code owner January 16, 2025 17:13
@va-vfs-bot va-vfs-bot temporarily deployed to API-43985-standard-data-service-spec/main/main January 16, 2025 17:39 Inactive
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we reference the method in the file name, in case we need to add other standard_data_service calls in the future?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants