Handle edge case where menu is not defined. (#804)

department-of-veterans-affairs · Nov 5, 2024 · e658209 · e658209
1 parent 59729e8
commit e658209
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 10 deletions.
diff --git a/src/data/queries/pressReleaseListing.ts b/src/data/queries/pressReleaseListing.ts
@@ -70,10 +70,13 @@ export const data: QueryData<
       )
 
   // Fetch the menu name dynamically off of the field_office reference
-  const menu = await getMenu(
-    entity.field_office.field_system_menu.resourceIdObjMeta
-      .drupal_internal__target_id
-  )
+  let menu = null
+  if (entity.field_office.field_system_menu) {
+    menu = await getMenu(
+      entity.field_office.field_system_menu.resourceIdObjMeta
+        ?.drupal_internal__target_id
+    )
+  }
 
   return {
     entity,

diff --git a/src/data/queries/storyListing.ts b/src/data/queries/storyListing.ts
@@ -66,12 +66,14 @@ export const data: QueryData<ListingPageDataOpts, StoryListingData> = async (
         listingParams(entity.id),
         PAGE_SIZE
       )
-
   // Fetch the menu name dynamically off of the field_office reference
-  const menu = await getMenu(
-    entity.field_office.field_system_menu.resourceIdObjMeta
-      .drupal_internal__target_id
-  )
+  let menu = null
+  if (entity.field_office.field_system_menu) {
+    menu = await getMenu(
+      entity.field_office.field_system_menu.resourceIdObjMeta
+        ?.drupal_internal__target_id
+    )
+  }
 
   return {
     entity,

diff --git a/src/lib/drupal/facilitySideNav.ts b/src/lib/drupal/facilitySideNav.ts
@@ -24,7 +24,7 @@ const normalizeMenuItem = (item: MenuItem): SideNavItem => {
 
 const normalizeMenuData = (menu: Menu): SideNavData => {
   // Bail early if no tree is provided
-  if (!menu.tree || menu.tree.length === 0) return null
+  if (!menu || !menu.tree || menu.tree.length === 0) return null
 
   const links = []
   menu.tree.forEach((item) => {