Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING(log): remove NOTSET LogLevel #6078

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

timreichen
Copy link
Contributor

@timreichen timreichen commented Sep 28, 2024

Changes
This PR removes the NOTSET LogLevel.

Reasoning
Instead of NOTSET loggers should be initialized with the default set LogLevel (which is INFO).

Copy link

codecov bot commented Sep 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.49%. Comparing base (69858cf) to head (a5f506a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6078      +/-   ##
==========================================
- Coverage   96.49%   96.49%   -0.01%     
==========================================
  Files         535      535              
  Lines       41281    41280       -1     
  Branches     6163     6163              
==========================================
- Hits        39833    39832       -1     
  Misses       1404     1404              
  Partials       44       44              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kt3k kt3k added the feedback welcome We want community's feedback on this issue or PR label Oct 8, 2024
@kt3k
Copy link
Member

kt3k commented Nov 14, 2024

There seem some dependencies to this symbol. https://github.com/search?q=NOTSET+language%3ATypeScript+std%2Flog&type=code

I don't find much value to this change, while it has some negative effects to the above users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback welcome We want community's feedback on this issue or PR log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants