-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING(log): remove NOTSET
LogLevel
#6078
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6078 +/- ##
==========================================
- Coverage 96.49% 96.49% -0.01%
==========================================
Files 535 535
Lines 41281 41280 -1
Branches 6163 6163
==========================================
- Hits 39833 39832 -1
Misses 1404 1404
Partials 44 44 ☔ View full report in Codecov by Sentry. |
There seem some dependencies to this symbol. https://github.com/search?q=NOTSET+language%3ATypeScript+std%2Flog&type=code I don't find much value to this change, while it has some negative effects to the above users. |
Changes
This PR removes the
NOTSET
LogLevel
.Reasoning
Instead of
NOTSET
loggers should be initialized with the default setLogLevel
(which isINFO
).