Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor server tests #99

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Conversation

deer
Copy link
Contributor

@deer deer commented Jan 29, 2024

@crowlKats, would you be able to take a look? I pulled this code out of #96 since it's not directly related to yaml. Once this PR is merged, I'll go back to the following and refactor them to use this new pattern:

The point of this change is to make it easier to define test cases that should verify css and have a way to visually inspect the case. I've done this by introducing a server task that allows the developer to browse a list of cases and view them.

Copy link
Member

@crowlKats crowlKats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crowlKats crowlKats merged commit 2582968 into denoland:main Jan 29, 2024
1 check passed
@deer deer deleted the server_test_refactor branch January 29, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants