Merge pull request #95 from prakhar-pal/fix-getters-not-reactive

bugfix: fix the issue where getters are not updated after state has been updated
dennybiasiolli · Mar 20, 2022 · ba2c50a · ba2c50a
2 parents 5578722 + 55cd3f8
commit ba2c50a
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/components/connect.js b/src/components/connect.js
@@ -29,19 +29,19 @@ export default (
         ...this.mappedGetters,
       };
 
-      if (this.mappedState) {
+      if (this.mappedState || this.mappedGetters) {
         this.unsubscribeFn = this.store.subscribe((mutation, state) => {
           let newState = {};
           // update state from store state
-          const newMappedState = mapStateToPropsFn(state, this.props);
+          const newMappedState = mapStateToPropsFn && mapStateToPropsFn(state, this.props);
           if (!shallowEqual(this.mappedState, newMappedState)) {
             this.mappedState = newMappedState;
             newState = { ...newState, ...this.mappedState };
           }
 
           // update state from store getters, if any
           if (this.mappedGetters) {
-            const newMappedGetters = mapGetterToPropsFn(this.store.getters, this.props);
+            const newMappedGetters = mapGetterToPropsFn && mapGetterToPropsFn(this.store.getters, this.props);
             if (!shallowEqual(this.mappedGetters, newMappedGetters)) {
               this.mappedGetters = newMappedGetters;
               newState = { ...newState, ...this.mappedGetters };