Print ETA #436
Open
Print ETA #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What do you mean “SHOULD”?
I didn’t like curr<eta, so I replaced it with curr/total.
…On Sat, Feb 16, 2019 at 1:10 AM Ekin Akyürek ***@***.***> wrote:
I believe here we print total time, instead we should print ETA.
------------------------------
You can view, comment on, or merge this pull request online at:
#436
Commit Summary
- Print ETA
File Changes
- *M* src/progress.jl
<https://github.com/denizyuret/Knet.jl/pull/436/files#diff-0> (2)
Patch Links:
- https://github.com/denizyuret/Knet.jl/pull/436.patch
- https://github.com/denizyuret/Knet.jl/pull/436.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#436>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABvNpnyPi9LdB5vdAKkGCwh8DcmRCDxvks5vNzBBgaJpZM4a-hlI>
.
|
|
Opps, I assume you meant to print ETA but accidently print Total. That’s why I said should.
Although it is not important, however, original tqdm is also prints curr<eta which I more like.
https://pypi.org/project/tqdm/ <https://pypi.org/project/tqdm/>
my logic is:
-You wonder how much time remained to complete this loop
-You can see how much time taken in the end
… On 16 Feb 2019, at 00:05, denizyuret ***@***.***> wrote:
What do you mean “SHOULD”?
I didn’t like curr<eta, so I replaced it with curr/total.
On Sat, Feb 16, 2019 at 1:10 AM Ekin Akyürek ***@***.***>
wrote:
> I believe here we print total time, instead we should print ETA.
> ------------------------------
> You can view, comment on, or merge this pull request online at:
>
> #436
> Commit Summary
>
> - Print ETA
>
> File Changes
>
> - *M* src/progress.jl
> <https://github.com/denizyuret/Knet.jl/pull/436/files#diff-0> (2)
>
> Patch Links:
>
> - https://github.com/denizyuret/Knet.jl/pull/436.patch
> - https://github.com/denizyuret/Knet.jl/pull/436.diff
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <#436>, or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ABvNpnyPi9LdB5vdAKkGCwh8DcmRCDxvks5vNzBBgaJpZM4a-hlI>
> .
>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#436 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AOpr8akPnTm6nAyKCPmoNTWEaYLdghE9ks5vN5GagaJpZM4a-hlI>.
|
|
- also, addition is generally easier than subtraction (curr+eta vs total-curr)
… On 16 Feb 2019, at 00:13, Ekin Akyürek ***@***.***> wrote:
Opps, I assume you meant to print ETA but accidently print Total. That’s why I said should.
Although it is not important, however, original tqdm is also prints curr<eta which I more like.
https://pypi.org/project/tqdm/ <https://pypi.org/project/tqdm/>
my logic is:
-You wonder how much time remained to complete this loop
-You can see how much time taken in the end
> On 16 Feb 2019, at 00:05, denizyuret ***@***.*** ***@***.***>> wrote:
>
> What do you mean “SHOULD”?
>
> I didn’t like curr<eta, so I replaced it with curr/total.
>
> On Sat, Feb 16, 2019 at 1:10 AM Ekin Akyürek ***@***.*** ***@***.***>>
> wrote:
>
> > I believe here we print total time, instead we should print ETA.
> > ------------------------------
> > You can view, comment on, or merge this pull request online at:
> >
> > #436 <#436>
> > Commit Summary
> >
> > - Print ETA
> >
> > File Changes
> >
> > - *M* src/progress.jl
> > <https://github.com/denizyuret/Knet.jl/pull/436/files#diff-0 <https://github.com/denizyuret/Knet.jl/pull/436/files#diff-0>> (2)
> >
> > Patch Links:
> >
> > - https://github.com/denizyuret/Knet.jl/pull/436.patch <https://github.com/denizyuret/Knet.jl/pull/436.patch>
> > - https://github.com/denizyuret/Knet.jl/pull/436.diff <https://github.com/denizyuret/Knet.jl/pull/436.diff>
> >
> > —
> > You are receiving this because you are subscribed to this thread.
> > Reply to this email directly, view it on GitHub
> > <#436 <#436>>, or mute the thread
> > <https://github.com/notifications/unsubscribe-auth/ABvNpnyPi9LdB5vdAKkGCwh8DcmRCDxvks5vNzBBgaJpZM4a-hlI <https://github.com/notifications/unsubscribe-auth/ABvNpnyPi9LdB5vdAKkGCwh8DcmRCDxvks5vNzBBgaJpZM4a-hlI>>
> > .
> >
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub <#436 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AOpr8akPnTm6nAyKCPmoNTWEaYLdghE9ks5vN5GagaJpZM4a-hlI>.
>
|
|
:)
I will think about it.
…On Sat, Feb 16, 2019, 8:18 AM Ekin Akyürek ***@***.*** wrote:
- also, addition is generally easier than subtraction :)
> On 16 Feb 2019, at 00:13, Ekin Akyürek ***@***.***> wrote:
>
> Opps, I assume you meant to print ETA but accidently print Total. That’s
why I said should.
>
> Although it is not important, however, original tqdm is also prints
curr<eta which I more like.
> https://pypi.org/project/tqdm/ <https://pypi.org/project/tqdm/>
>
> my logic is:
> -You wonder how much time remained to complete this loop
> -You can see how much time taken in the end
>
>
>
>
>> On 16 Feb 2019, at 00:05, denizyuret ***@***.*** <mailto:
***@***.***>> wrote:
>>
>> What do you mean “SHOULD”?
>>
>> I didn’t like curr<eta, so I replaced it with curr/total.
>>
>> On Sat, Feb 16, 2019 at 1:10 AM Ekin Akyürek ***@***.***
***@***.***>>
>> wrote:
>>
>> > I believe here we print total time, instead we should print ETA.
>> > ------------------------------
>> > You can view, comment on, or merge this pull request online at:
>> >
>> > #436 <
#436>
>> > Commit Summary
>> >
>> > - Print ETA
>> >
>> > File Changes
>> >
>> > - *M* src/progress.jl
>> > <https://github.com/denizyuret/Knet.jl/pull/436/files#diff-0 <
https://github.com/denizyuret/Knet.jl/pull/436/files#diff-0>> (2)
>> >
>> > Patch Links:
>> >
>> > - https://github.com/denizyuret/Knet.jl/pull/436.patch <
https://github.com/denizyuret/Knet.jl/pull/436.patch>
>> > - https://github.com/denizyuret/Knet.jl/pull/436.diff <
https://github.com/denizyuret/Knet.jl/pull/436.diff>
>> >
>> > —
>> > You are receiving this because you are subscribed to this thread.
>> > Reply to this email directly, view it on GitHub
>> > <#436 <
#436>>, or mute the thread
>> > <
https://github.com/notifications/unsubscribe-auth/ABvNpnyPi9LdB5vdAKkGCwh8DcmRCDxvks5vNzBBgaJpZM4a-hlI
<
https://github.com/notifications/unsubscribe-auth/ABvNpnyPi9LdB5vdAKkGCwh8DcmRCDxvks5vNzBBgaJpZM4a-hlI
>>
>> > .
>> >
>> —
>> You are receiving this because you authored the thread.
>> Reply to this email directly, view it on GitHub <
#436 (comment)>,
or mute the thread <
https://github.com/notifications/unsubscribe-auth/AOpr8akPnTm6nAyKCPmoNTWEaYLdghE9ks5vN5GagaJpZM4a-hlI
>.
>>
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#436 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABvNpig2BYt8y2hYgL8Duh_ftLYLxBBBks5vN5SugaJpZM4a-hlI>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe here we print total time, instead we should print ETA.