Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duo array log type not updating #37275

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

omerKarkKatz
Copy link
Contributor

@omerKarkKatz omerKarkKatz commented Nov 18, 2024

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

Fixed an issue where the log type array parameter would not get update when changed if a last run object already exists.

Must have

  • Tests
  • Documentation

Copy link

github-actions bot commented Nov 18, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/DuoAdminApi/Integrations/DuoEventCollector
   DuoEventCollector.py2413187%67–68, 70–71, 75–79, 81, 83, 130, 171, 284–286, 292–293, 311, 440, 447, 459–460, 464, 468–471, 478, 480–481
TOTAL2413187% 

Tests Skipped Failures Errors Time
34 0 💤 0 ❌ 0 🔥 2.711s ⏱️

Copy link
Contributor

@RotemAmit RotemAmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants