Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: configure reactive map zoom with out without address #357

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

Yolijn
Copy link
Contributor

@Yolijn Yolijn commented Dec 27, 2024

  1. When no address is selected listen to new map.default_zoom option or fallback to zoom level 12
  2. When an address is selected listen to map.minimal_zoom or fallback to zoom level 18
  3. Only show map markers and feature list when an address is available in formState
  4. Also change zoom level when input in vulaan step changes

Copy link

vercel bot commented Dec 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
signalen-frontend-wcag ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 27, 2024 4:16pm

@Yolijn Yolijn requested a review from Robbert December 27, 2024 15:18
@Yolijn Yolijn requested a review from iehkaatee December 27, 2024 16:13
@Robbert
Copy link
Contributor

Robbert commented Dec 27, 2024

Werkt wel mooi zo! De zoomniveau's zijn voor mij veel intuitiever nu.

@Yolijn Yolijn linked an issue Dec 27, 2024 that may be closed by this pull request
@iehkaatee
Copy link
Contributor

Helemaal mee eens, ziet er beter uit zo!

@iehkaatee iehkaatee merged commit 548840f into main Dec 30, 2024
8 checks passed
@iehkaatee iehkaatee deleted the fix/map-zoom-without-address branch December 30, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kaart gedrag bij selecteren van adres
3 participants