[Kernel] Fix RoaringBitmapArray create/add methods. Closes issue #3881 #3882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The bitmaps array should be initialized in the `create` path. - The `expandBitMaps` method should set new bitmaps from the old length up to the new length, instead of overwriting the old ones. - Adds a `toArray` method mimicking the one provided by the scala version which the class is based on. Signed-off-by: Antoni Reus <[email protected]>
Signed-off-by: Antoni Reus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
Resolves #3881
createpath.expandBitMapsmethod should set new bitmaps from the old length up to the new length, instead of overwriting the old ones.Also adds a
toArraymethod mimicking the one provided by the scala version which the class is based on.How was this patch tested?
Added unit tests.
Does this PR introduce any user-facing changes?
No