chore: expand the arrow version range to allow arrow v54 #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was released last week and in preliminary testing it appears safe to incorporate for the latest version range Note: Field.dict_id() is going away, and where it is being used for field comparisons I don't believe it adds substantial value. There's no replacement for it in Arrow 54+ Signed-off-by: R. Tyler Croy <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #616 +/- ##
=======================================
Coverage 83.50% 83.50%
=======================================
Files 74 74
Lines 16919 16916 -3
Branches 16919 16916 -3
=======================================
- Hits 14128 14126 -2
+ Misses 2133 2132 -1
Partials 658 658 ☔ View full report in Codecov by Sentry. |
scovich
reviewed
Jan 1, 2025
Comment on lines
-106
to
-109
| assert!( | ||
| actual_field.dict_id() == expected_field.dict_id(), | ||
| "Field dict_id doesn't match" | ||
| ); |
There was a problem hiding this comment.
No, arrow 54 marks dict_id as deprecated and the function will be removed in 55
zachschuermann
approved these changes
Jan 8, 2025
| arrow-schema = { version = ">=53, <54" } | ||
| parquet = { version = ">=53, <54", features = ["object_store"] } | ||
| # When changing the arrow version range, also modify ffi/Cargo.toml which has | ||
| # its own arrow version ranges witeh modified features. Failure to do so will |
There was a problem hiding this comment.
Suggested change
| # its own arrow version ranges witeh modified features. Failure to do so will | |
| # its own arrow version ranges with modified features. Failure to do so will |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was released last week and in preliminary testing it appears safe to incorporate for the latest version range
What changes are proposed in this pull request?
How was this change tested?