-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wip] add in-commit timestamps table properties #558
base: main
Are you sure you want to change the base?
Conversation
Mention: #559 |
props.enable_in_commit_timestamps = Some(parse_bool(v)?) | ||
} | ||
"delta.inCommitTimestampEnablementVersion" => { | ||
props.in_commit_timestamp_enablement_version = Some(parse_int(v)?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something went wrong:
error[E0425]: cannot find function `parse_int` in this scope
--> /Users/runner/work/delta-kernel-rs/delta-kernel-rs/kernel/src/table_properties/deserialize.rs:83:65
|
83 | props.in_commit_timestamp_enablement_version = Some(parse_int(v)?)
| ^^^^^^^^^ not found in this scope
error[E0425]: cannot find function `parse_int` in this scope
--> /Users/runner/work/delta-kernel-rs/delta-kernel-rs/kernel/src/table_properties/deserialize.rs:86:67
|
86 | props.in_commit_timestamp_enablement_timestamp = Some(parse_int(v)?)
| ^^^^^^^^^ not found in this scope
(I think all the other int properties use parse_positive_int
and parse_int
may not even exist?)
(these two do need to tolerate 0)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea sorry opened this as a sort of "todo" and will fix this :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry should have probably made it a draft...
What changes are proposed in this pull request?
How was this change tested?