Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github actions to aid the release process #557

Merged
merged 3 commits into from
Nov 7, 2024
Merged

Conversation

shaynafinocchiaro
Copy link
Contributor

@shaynafinocchiaro shaynafinocchiaro commented Nov 6, 2024

Is this a new chart?

No

What this PR does / why we need it:

This PR adds 2 additional github actions

  • Post Release Action updates references of target-branch, mostly for dependabot
  • Sync Release Branch with Main will try to rebase the feature branch with main when there are pushes to main branch. If a rebase can't be performed automatically, an issue is created and assigned to the person who last merged to main. This is done in hopes to ease the release of the helm-charts.

Which issue(s) is this PR associated with:

Special notes for your reviewer:

Checklist:

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Variables are documented in the chart README.md
  • Title of the PR starts with the chart name (e.g. [charts_dir/mychartname]) if applicable
    Screenshot 2024-11-07 093222
    Screenshot 2024-11-07 093306

alikdell
alikdell previously approved these changes Nov 7, 2024
gallacher
gallacher previously approved these changes Nov 7, 2024
ChristianAtDell
ChristianAtDell previously approved these changes Nov 7, 2024
Copy link
Contributor

@ChristianAtDell ChristianAtDell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an impressive bit of work that could make releases faster/more automated. Has it been tested in a private clone of the repository to make sure it creates the proper branch? Does it do any tagging? I didn't see actions for that but I figure that's the next logical step.

atye
atye previously approved these changes Nov 7, 2024
@shaynafinocchiaro
Copy link
Contributor Author

This is an impressive bit of work that could make releases faster/more automated. Has it been tested in a private clone of the repository to make sure it creates the proper branch? Does it do any tagging? I didn't see actions for that but I figure that's the next logical step.

@ChristianAtDell I did all the testing in a forked repo. I'll attach screenshots to the PR description. These actions don't do any releasing. That's already handled by https://github.com/dell/helm-charts/blob/main/.github/workflows/charts-release-action.yml and https://github.com/dell/helm-charts/blob/main/.github/workflows/wizard-release-action.yml. This is mainly to prevent having to rebase a ton of changes at the end of the release since there's a lot of room for human error.

Copy link
Collaborator

@tdawe tdawe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shaynafinocchiaro shaynafinocchiaro merged commit 4d2e7ed into main Nov 7, 2024
3 checks passed
@shaynafinocchiaro shaynafinocchiaro deleted the add-actions branch November 7, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants