-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add github actions to aid the release process #557
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an impressive bit of work that could make releases faster/more automated. Has it been tested in a private clone of the repository to make sure it creates the proper branch? Does it do any tagging? I didn't see actions for that but I figure that's the next logical step.
@ChristianAtDell I did all the testing in a forked repo. I'll attach screenshots to the PR description. These actions don't do any releasing. That's already handled by https://github.com/dell/helm-charts/blob/main/.github/workflows/charts-release-action.yml and https://github.com/dell/helm-charts/blob/main/.github/workflows/wizard-release-action.yml. This is mainly to prevent having to rebase a ton of changes at the end of the release since there's a lot of room for human error. |
55696b4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Is this a new chart?
No
What this PR does / why we need it:
This PR adds 2 additional github actions
Which issue(s) is this PR associated with:
Special notes for your reviewer:
Checklist:
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[charts_dir/mychartname]
) if applicable