Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[charts/csi-powerstore] Centralize all images to one place #264

Closed
wants to merge 4 commits into from

Conversation

coulof
Copy link
Collaborator

@coulof coulof commented Aug 24, 2023

Is this a new chart?

No

What this PR does / why we need it:

Simplify images customization by centralizing them in one place

Which issue(s) is this PR associated with:

  • KRV-12738

Special notes for your reviewer:

/!\ Only the syntax has been tested (passed with helm install powerstore ./csi-powerstore -n powerstore --debug --dry-run) per agreement on Slack the Scrum team will validate the e2e installation.

Checklist:

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Variables are documented in the chart README.md
  • Title of the PR starts with the chart name (e.g. [charts_dir/mychartname]) if applicable

@coulof coulof changed the title [charts/csi-powerflex] Centralize all images to one place [charts/csi-powerstore] Centralize all images to one place Aug 24, 2023
healthmonitor: registry.k8s.io/sig-storage/csi-external-health-monitor-controller:v0.9.0

# CSM sidecars
replication: dellemc/dell-csi-replicator:v1.5.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the image for dell-csi-replicator to v1.6.0

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

# CSM sidecars
replication: dellemc/dell-csi-replicator:v1.5.0
vgsnapshotter: dellemc/csi-volumegroup-snapshotter:v1.2.0
podmon: dellemc/podmon:v1.6.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the image for podmon to v1.7.0

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

replication: dellemc/dell-csi-replicator:v1.5.0
vgsnapshotter: dellemc/csi-volumegroup-snapshotter:v1.2.0
podmon: dellemc/podmon:v1.6.0
authorization: dellemc/csm-authorization-sidecar:v1.7.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Powerstore does not support authorization so this can be removed.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

vgsnapshotter: dellemc/csi-volumegroup-snapshotter:v1.2.0
podmon: dellemc/podmon:v1.6.0
authorization: dellemc/csm-authorization-sidecar:v1.7.0
metadataretriever: dellemc/csi-metadata-retriever:v1.4.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the image for csi-metadata-retriever to v1.5.0

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@suryagupta4
Copy link
Contributor

@coulof Left some comments. Please have a look. Thanks.

@wrender
Copy link

wrender commented Sep 26, 2023

Thanks for this. Although what about doing it this way (below)? For example, you can keep the .tpl logic that is checking the kubernetes versions? I think most people just want to overide the repository? and not maintain the specific container versions, because that really depends on the kubernetes cluster version?

{{- define "csi-isilon.attacherImage" -}}
  {{- if eq .Capabilities.KubeVersion.Major "1" }}
    {{- if and (ge (trimSuffix "+" .Capabilities.KubeVersion.Minor) "21") (le (trimSuffix "+" .Capabilities.KubeVersion.Minor) "28") -}}
      {{- print .Values.images.helperRepository "/csi-attacher:v4.3.0" -}}
    {{- end -}}
  {{- end -}}
{{- end -}}

And then in the values you can just set the registry like this:

  metadataretriever:
    image: /csi-metadata-retriever:v1.4.0

    # image: Image to use for dell-csi-replicator. This shouldn't be changed
    # Allowed values: string
    # Default value: None
    image: /dell-csi-replicator:v1.6.0

images:
  # "driver" defines the container image, used for the driver container.
  driverRepository: dellemc
  helperRepository: registry.k8s.io/sig-storage

@coulof coulof changed the base branch from release-v1.8.0 to release-v1.9.0 October 18, 2023 07:37
@coulof coulof changed the base branch from release-v1.9.0 to release-v1.8.0 October 18, 2023 07:40
@coulof coulof changed the base branch from release-v1.8.0 to release-v1.9.0 October 18, 2023 08:10
@coulof coulof changed the base branch from release-v1.9.0 to release-v1.8.0 October 18, 2023 08:10
@coulof
Copy link
Collaborator Author

coulof commented Oct 18, 2023

replaced by #310

@coulof coulof closed this Oct 18, 2023
@coulof coulof deleted the pstore-driver-images branch April 17, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants