-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[charts/csi-powerstore] Centralize all images to one place #264
Conversation
charts/csi-powerstore/values.yaml
Outdated
healthmonitor: registry.k8s.io/sig-storage/csi-external-health-monitor-controller:v0.9.0 | ||
|
||
# CSM sidecars | ||
replication: dellemc/dell-csi-replicator:v1.5.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the image for dell-csi-replicator to v1.6.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
charts/csi-powerstore/values.yaml
Outdated
# CSM sidecars | ||
replication: dellemc/dell-csi-replicator:v1.5.0 | ||
vgsnapshotter: dellemc/csi-volumegroup-snapshotter:v1.2.0 | ||
podmon: dellemc/podmon:v1.6.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the image for podmon to v1.7.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
charts/csi-powerstore/values.yaml
Outdated
replication: dellemc/dell-csi-replicator:v1.5.0 | ||
vgsnapshotter: dellemc/csi-volumegroup-snapshotter:v1.2.0 | ||
podmon: dellemc/podmon:v1.6.0 | ||
authorization: dellemc/csm-authorization-sidecar:v1.7.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Powerstore does not support authorization so this can be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
charts/csi-powerstore/values.yaml
Outdated
vgsnapshotter: dellemc/csi-volumegroup-snapshotter:v1.2.0 | ||
podmon: dellemc/podmon:v1.6.0 | ||
authorization: dellemc/csm-authorization-sidecar:v1.7.0 | ||
metadataretriever: dellemc/csi-metadata-retriever:v1.4.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the image for csi-metadata-retriever to v1.5.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
@coulof Left some comments. Please have a look. Thanks. |
Thanks for this. Although what about doing it this way (below)? For example, you can keep the .tpl logic that is checking the kubernetes versions? I think most people just want to overide the repository? and not maintain the specific container versions, because that really depends on the kubernetes cluster version?
And then in the values you can just set the registry like this:
|
replaced by #310 |
Is this a new chart?
No
What this PR does / why we need it:
Simplify images customization by centralizing them in one place
Which issue(s) is this PR associated with:
Special notes for your reviewer:
/!\ Only the syntax has been tested (passed with
helm install powerstore ./csi-powerstore -n powerstore --debug --dry-run
) per agreement on Slack the Scrum team will validate the e2e installation.Checklist:
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[charts_dir/mychartname]
) if applicable