Standalone helm support for PowerFlex #249
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KshitijaKakde
requested review from
gallacher,
tdawe,
alikdell,
atye,
hoppea2,
chaganti-rajitha,
coulof,
meggm,
niranjan-n1,
shaynafinocchiaro,
sharmilarama,
tssushma,
taohe1012,
P-Cao,
shanmydell,
baoy1,
YianZong and
forrestxia
as code owners
meggm
reviewed
Aug 8, 2023
Done |
VamsiSiddu-7
reviewed
Aug 8, 2023
There was a problem hiding this comment.
@KshitijaKakde you can keep this file as it is. Looking at the changes i see the placement of the filelds is different here. There were no changes to the values.
VamsiSiddu-7
reviewed
Aug 8, 2023
| @@ -16,5 +16,4 @@ keywords: | |||
| maintainers: | |||
| - name: DellEMC | |||
| sources: | |||
| - https://github.com/dell/csi-vxflexos | |||
There was a problem hiding this comment.
add the removed new line back
niranjan-n1
reviewed
Aug 8, 2023
| @@ -245,6 +279,21 @@ node: | |||
| # Default value: false | |||
| enabled: false | |||
|
|
|||
| # Storage Capacity Tracking | |||
| # Note: Capacity tracking is supported in kubernetes v1.24 and above, this feature will be automatically disabled in older versions. | |||
| storageCapacity: | |||
There was a problem hiding this comment.
Add this in container-storage-modules chart as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a new chart?
Yes/No
What this PR does / why we need it:
This PR address , standalone helm support for PowerFlex , it updates all the required files in csi-vxflexos
Which issue(s) is this PR associated with:
Special notes for your reviewer:
Checklist:
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[charts_dir/mychartname]) if applicable