Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PowerScale e2e alternate values tests in OCP cluster #780

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fix PowerScale e2e alternate values tests in OCP cluster #780

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
504bdd3
E2E testcase fixes for OCP
gilltaran Nov 14, 2024
bdcfe49
indentation correction
gilltaran Nov 14, 2024
01c3acf
fix trailing space issue
gilltaran Nov 14, 2024
0aae1ad
fix trailing space issue
gilltaran Nov 14, 2024
d7ef61c
fix trailing space issue
gilltaran Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions tests/e2e/testfiles/storage_csm_powerscale_alt_vals_1.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,10 @@ spec:
- key: "node-role.kubernetes.io/control-plane"
operator: "Exists"
effect: "NoSchedule"
# Uncomment if nodes you wish to use have the node-role.kubernetes.io/master taint
- key: "node-role.kubernetes.io/master"
operator: "Exists"
effect: "NoSchedule"
node:
envs:
# X_CSI_MAX_VOLUMES_PER_NODE: Specify default value for maximum number of volumes that controller can publish to the node.
Expand Down Expand Up @@ -225,6 +229,10 @@ spec:
- key: "node-role.kubernetes.io/control-plane"
operator: "Exists"
effect: "NoSchedule"
# Uncomment if nodes you wish to use have the node-role.kubernetes.io/master taint
- key: "node-role.kubernetes.io/master"
operator: "Exists"
effect: "NoSchedule"
sideCars:
- name: provisioner
args: ["--volume-name-prefix=pscale"]
Expand Down
32 changes: 20 additions & 12 deletions tests/e2e/testfiles/storage_csm_powerscale_alt_vals_2.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,10 @@
- key: "node-role.kubernetes.io/control-plane"
operator: "Exists"
effect: "NoSchedule"
# Uncomment if nodes you wish to use have the node-role.kubernetes.io/master taint
- key: "node-role.kubernetes.io/master"
operator: "Exists"
effect: "NoSchedule"
node:
envs:
# X_CSI_MAX_VOLUMES_PER_NODE: Specify default value for maximum number of volumes that controller can publish to the node.
Expand Down Expand Up @@ -196,19 +200,23 @@
# tolerations: Define tolerations for the node daemonset, if required.
# Default value: None
tolerations:
# - key: "node.kubernetes.io/memory-pressure"
# operator: "Exists"
# effect: "NoExecute"
# - key: "node.kubernetes.io/disk-pressure"
# operator: "Exists"
# effect: "NoExecute"
# - key: "node.kubernetes.io/network-unavailable"
# operator: "Exists"
# effect: "NoExecute"
- key: "node.kubernetes.io/memory-pressure"
operator: "Exists"
effect: "NoExecute"
- key: "node.kubernetes.io/disk-pressure"
operator: "Exists"
effect: "NoExecute"
- key: "node.kubernetes.io/network-unavailable"
operator: "Exists"
effect: "NoExecute"
# Uncomment if nodes you wish to use have the node-role.kubernetes.io/control-plane taint

Check warning on line 212 in tests/e2e/testfiles/storage_csm_powerscale_alt_vals_2.yaml

View workflow job for this annotation

GitHub Actions / Golang Validation / Yaml Lint 

212:7 [comments-indentation] comment not indented like content
# - key: "node-role.kubernetes.io/control-plane"
# operator: "Exists"
# effect: "NoSchedule"
- key: "node-role.kubernetes.io/control-plane"
operator: "Exists"
effect: "NoSchedule"
# Uncomment if nodes you wish to use have the node-role.kubernetes.io/master taint

Check warning on line 216 in tests/e2e/testfiles/storage_csm_powerscale_alt_vals_2.yaml

View workflow job for this annotation

GitHub Actions / Golang Validation / Yaml Lint 

216:8 [comments-indentation] comment not indented like content
- key: "node-role.kubernetes.io/master"
operator: "Exists"
effect: "NoSchedule"
sideCars:
- name: provisioner
args: ["--volume-name-prefix=csipscale"]
Expand Down
14 changes: 11 additions & 3 deletions tests/e2e/testfiles/storage_csm_powerscale_alt_vals_3.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,10 +149,14 @@
# tolerations: Define tolerations for the controller deployment, if required.
# Default value: None
tolerations:
# Uncomment if nodes you wish to use have the node-role.kubernetes.io/control-plane taint

Check warning on line 152 in tests/e2e/testfiles/storage_csm_powerscale_alt_vals_3.yaml

View workflow job for this annotation

GitHub Actions / Golang Validation / Yaml Lint 

152:7 [comments-indentation] comment not indented like content
# - key: "node-role.kubernetes.io/control-plane"
# operator: "Exists"
# effect: "NoSchedule"
- key: "node-role.kubernetes.io/control-plane"
operator: "Exists"
effect: "NoSchedule"
# Uncomment if nodes you wish to use have the node-role.kubernetes.io/master taint

Check warning on line 156 in tests/e2e/testfiles/storage_csm_powerscale_alt_vals_3.yaml

View workflow job for this annotation

GitHub Actions / Golang Validation / Yaml Lint 

156:7 [comments-indentation] comment not indented like content
- key: "node-role.kubernetes.io/master"
operator: "Exists"
effect: "NoSchedule"
node:
envs:
# X_CSI_MAX_VOLUMES_PER_NODE: Specify default value for maximum number of volumes that controller can publish to the node.
Expand Down Expand Up @@ -209,6 +213,10 @@
- key: "node-role.kubernetes.io/control-plane"
operator: "Exists"
effect: "NoSchedule"
# Uncomment if nodes you wish to use have the node-role.kubernetes.io/master taint
- key: "node-role.kubernetes.io/master"
operator: "Exists"
effect: "NoSchedule"
sideCars:
- name: provisioner
args: ["--volume-name-prefix=csipscale"]
Expand Down
Loading