Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated podmon version in installation wizard #1244

Merged
merged 10 commits into from
Sep 18, 2024
Merged

updated podmon version in installation wizard #1244

merged 10 commits into from
Sep 18, 2024

Conversation

niranjan-n1
Copy link
Contributor

@niranjan-n1 niranjan-n1 commented Sep 4, 2024 •
edited by chimanjain
Loading

Description

  1. Added operator template for csm 1.12
  2. updated podmon and replication version in installation wizard
  3. updated observability version in installation wizard
  4. Helm chart changes addressed in charts/container-storage-modules updated podmon version helm-charts#504

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1435

Checklist:

  • Have you run a grammar and spell checks against your submission?
  • Have you tested the changes locally?
  • [] Have you tested whether the hyperlinks are working properly?
  • [] Did you add the examples wherever applicable?
  • Have you added high-resolution images?

@niranjan-n1 niranjan-n1 self-assigned this Sep 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2024 •
edited
Loading

Test Results

76 tests  ±0   76 ✅ ±0   3s ⏱️ ±0s
 3 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 75e65f4. ± Comparison against base commit 45b6483.

♻️ This comment has been updated with latest results.

@niranjan-n1 niranjan-n1 marked this pull request as ready for review September 5, 2024 10:51
gallacher
gallacher previously requested changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@gallacher gallacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@niranjan-n1 - please ensure all version updates in this repository are happening at the same time to drive consistency. Thanks!

@niranjan-n1
Copy link
Contributor Author

@niranjan-n1 - please ensure all version updates in this repository are happening at the same time to drive consistency. Thanks!

Hi @gallacher, Installation wizard changes for csm 1.12 for drivers in helm is already added for the drivers in this PR https://github.com/dell/csm-docs/pull/1233/files#diff-8c916df10fa4b13e493875bfac6c8ad7658fb3040242b671f34c357c2edf73ce.

@chimanjain chimanjain force-pushed the usr/Niranjan/update-podmon-versions branch from 3ca621f to b2af7e0 Compare September 9, 2024 16:57
@niranjan-n1 niranjan-n1 dismissed gallacher’s stale review September 17, 2024 10:24

Addressed the review comment

santhoshatdell
santhoshatdell reviewed Sep 17, 2024
View reviewed changes
content/docs/deployment/csminstallationwizard/src/templates/operator/csm-isilon-1.12.0.template
@@ -0,0 +1,484 @@
#
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the CSM 1.8 templates be deleted now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will check with the component owners and update. Thanks @santhoshatdell

rajkumar-palani
rajkumar-palani approved these changes Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@rajkumar-palani rajkumar-palani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@niranjan-n1 niranjan-n1 merged commit 30b7ab9 into main Sep 18, 2024
7 checks passed
@niranjan-n1 niranjan-n1 deleted the usr/Niranjan/update-podmon-versions branch September 18, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@santhoshatdell santhoshatdell santhoshatdell left review comments

@samihan-dell samihan-dell samihan-dell approved these changes

@karthikk92 karthikk92 karthikk92 approved these changes

@shefali-malhotra shefali-malhotra shefali-malhotra approved these changes

@khareRajshree khareRajshree khareRajshree approved these changes

@rajkumar-palani rajkumar-palani rajkumar-palani approved these changes

@atye atye Awaiting requested review from atye

@bharathsreekanth bharathsreekanth Awaiting requested review from bharathsreekanth

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari

@mdutka-dell mdutka-dell Awaiting requested review from mdutka-dell

@mgandharva mgandharva Awaiting requested review from mgandharva

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri

@rsedlock1958 rsedlock1958 Awaiting requested review from rsedlock1958 rsedlock1958 is a code owner

@shanmydell shanmydell Awaiting requested review from shanmydell

@sharont58 sharont58 Awaiting requested review from sharont58

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro

@suryagupta4 suryagupta4 Awaiting requested review from suryagupta4

@rishabhatdell rishabhatdell Awaiting requested review from rishabhatdell

@satyakonduri satyakonduri Awaiting requested review from satyakonduri

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@AronAtDell AronAtDell Awaiting requested review from AronAtDell AronAtDell is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

Assignees

@niranjan-n1 niranjan-n1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@niranjan-n1 @gallacher @rajkumar-palani @khareRajshree @shefali-malhotra @karthikk92 @santhoshatdell @samihan-dell @chimanjain