Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Glossary & table metadata string #80

Merged
merged 3 commits into from
Feb 6, 2024
Merged

Glossary & table metadata string #80

merged 3 commits into from
Feb 6, 2024

Conversation

wendy-aw
Copy link
Contributor

@wendy-aw wendy-aw commented Feb 6, 2024

  • Modified files to incorporate glossary and table_metadata_strings if provided by the data files.
  • If table_metadata_string is provided in the csv data file, pruning of metadata will not occur. This aids evaluation of queries independent of the pruning function.

rishsriv
rishsriv approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@rishsriv rishsriv left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for doing this PR and for making evals more reliable!

@rishsriv rishsriv merged commit 7833bc9 into main Feb 6, 2024
2 checks passed
@rishsriv rishsriv deleted the wendy/glossary branch February 6, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rishsriv rishsriv rishsriv approved these changes

@wongjingping wongjingping Awaiting requested review from wongjingping

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wendy-aw @rishsriv