Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refined advanced questions #103

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Refined advanced questions #103

merged 2 commits into from
Apr 2, 2024

Conversation

wongjingping
Copy link
Collaborator

Refined advanced questions after eye-balling through all the ones that one of the sqlcoder-7b variants currently fail in.
Updated api_runner to output num_tokens to know when we're hitting the max tokens limit.

Updated GPT-4 turbo results:

python3 main.py \
  -db postgres \
  -q data/instruct_advanced_postgres.csv \
  -o results/openai_gpt4_turbo_advanced.csv \
  -g oa \
  -f prompts/prompt_openai.md \
  -m gpt-4-0125-preview \
  -c 0 \
  -p 20
Preparing questions...
Using all questions from data/instruct_advanced_postgres.csv
Correct so far: 41/64 (64.06%): 100%|████████████████████████████████████████████████████████████████████████████████████████████████| 64/64 [00:50<00:00,  1.27it/s]
                 query_category  num_rows  mean_correct  mean_error_db_exec
0         instructions_cte_join        16        0.8125              0.0625
1       instructions_cte_window         8        0.3750              0.2500
2        instructions_date_join        16        0.5625              0.1875
3  instructions_string_matching         8        0.8750              0.0000
4            keywords_aggregate         8        0.8750              0.0000
5                keywords_ratio         8        0.2500              0.1250
Average correct rate: 0.64

output tokens used in api_runner
@wongjingping wongjingping requested a review from rishsriv April 2, 2024 09:36
Copy link
Member

@rishsriv rishsriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating these, and making the instructions clearer!

@rishsriv rishsriv merged commit e803f72 into main Apr 2, 2024
2 checks passed
@rishsriv rishsriv deleted the jp/adv_refine branch April 2, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants