Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Table plugins - pass through deprecated props #2308

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

mofojed
Copy link
Member

@mofojed mofojed commented Dec 9, 2024

- Deprecated props were not being passed through at all to the plugins
- We need to continue to pass through the deprecated props until we have a replacement
@mofojed mofojed requested a review from a team December 9, 2024 20:09
@mofojed mofojed self-assigned this Dec 9, 2024
@mofojed mofojed requested review from vbabich and removed request for a team December 9, 2024 20:09
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.70%. Comparing base (238f611) to head (c9428e4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2308   +/-   ##
=======================================
  Coverage   46.70%   46.70%           
=======================================
  Files         704      704           
  Lines       39011    39011           
  Branches     9745     9745           
=======================================
  Hits        18220    18220           
  Misses      20780    20780           
  Partials       11       11           
Flag Coverage Δ
unit 46.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mofojed mofojed enabled auto-merge (squash) December 9, 2024 20:14
@mofojed mofojed merged commit d884bff into deephaven:main Dec 9, 2024
11 checks passed
@mofojed mofojed deleted the fix-table-plugin-deprecated-props branch December 9, 2024 20:24
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants