fix: Add feature to control systemic property of executeCode #6519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcaudy
reviewed
Jan 5, 2025
...pdategraph/src/main/java/io/deephaven/engine/util/systemicmarking/SystemicObjectTracker.java
Outdated
Show resolved
Hide resolved
...pdategraph/src/main/java/io/deephaven/engine/util/systemicmarking/SystemicObjectTracker.java
Outdated
Show resolved
Hide resolved
abaranec
requested review from
devinrsmith,
nbauernfeind,
niloc132,
chipkent and
jmao-denver
as code owners
cpwright
previously approved these changes
Jan 6, 2025
devinrsmith
reviewed
Jan 6, 2025
server/src/main/java/io/deephaven/server/console/ConsoleServiceGrpcImpl.java
Outdated
Show resolved
Hide resolved
proto/proto-backplane-grpc/src/main/proto/deephaven_core/proto/console.proto
Outdated
Show resolved
Hide resolved
server/src/main/java/io/deephaven/server/console/ConsoleServiceGrpcImpl.java
Outdated
Show resolved
Hide resolved
|
Also, needs spotless. |
jmao-denver
reviewed
Jan 6, 2025
jmao-denver
reviewed
Jan 6, 2025
jmao-denver
reviewed
Jan 6, 2025
abaranec
changed the title
abaranec
changed the title
abaranec
changed the title
cpwright
reviewed
Jan 7, 2025
proto/proto-backplane-grpc/src/main/proto/deephaven_core/proto/console.proto
Outdated
Show resolved
Hide resolved
cpwright
previously approved these changes
Jan 7, 2025
|
javadoc failing, looks like simple fix |
…/console.proto Co-authored-by: Charles P. Wright <[email protected]>
… into abaranec_dh18318
rcaudy
reviewed
Jan 7, 2025
...pdategraph/src/main/java/io/deephaven/engine/util/systemicmarking/SystemicObjectTracker.java
Show resolved
Hide resolved
cpwright
approved these changes
Jan 7, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add markThreadNotSystemic() to support Core+, systemic object tracking in PQs