WIP: Make an explicit EncodedIndex and IndexShiftData table #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do this so the Barrage format is somewhat more self-documenting and has fewer instances of unadorned "[byte]" types.
Also, making IndexShiftData explicit allows code to stream over "starts", "ends", and "deltas" without having to first read them all into memory. Put another way, there are three indices embedded in IndexShiftData. Prior to this change you would not know where the "ends" index starts until you scanned all of the "starts" index. Likewise you would not know where the "deltas" index starts until you had scanned all the "ends" index.
Having them be explicit gives code the opportunity to start processing the IndexShiftData without necessarily reading through all of it first, which could provide an advantage.
These changes would increase the size of the messages by a constant number of bytes, and it would add a layer of indirection, but I don't think these costs would be significant.