-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display expired/missed tickets in /vsp table. #1148
Conversation
jholdstock
commented
Oct 26, 2023
•
edited
Loading
edited
⚠️ This should not be deployed before decred/dcrwebapi#180 and all VSPs are running vspd >=1.3.0
Nice! I have some ideas: 1. 2. How about renaming 3. How about also exposing block height? |
|
1. Yes I'd remove it. 2. Ah I didn't know tha "Voting" includes immature. I suggested "Live" because it sounds easier to understand (like they are "up" or "online", and also not "voting" right now but rather waiting when they can vote). I don't mind either now. 3. "what is the correct block height meant to be?" - I think 1-2 numbers not matching the other 13 would be enough to alert the user to check something else without even knowing what "block height" is. Maybe a "Check the latest block at the block explorer" link would be enough. But yeah this can be done in another PR. |
c15ae3e
to
0eceefe
Compare
0eceefe
to
c199e97
Compare
Nice! Another small thing is |