This repository has been archived by the owner on Oct 19, 2022. It is now read-only.
relax dependency on activesupport #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests are running fine with activesupport 5.2. Fixes deckar01#20
|
It looks like the tests are failing on Travis for master for some reason. Sorry for the inconvenience. I will take a look at it tonight. If you get it working before I do feel free to include the fix in this MR and I will by happy to review it. |
|
In my local system I have ruby 2.5 and nodejs 8. Error seems to be related to nodejs version used by phantomjs. |
nodejs 7 is end of life
|
I think its phantomjs that is end of life. I think pahntomjs should be changed to phantomjs-prebuilt in package.json |
Phantomjs is now phantomjs-prebuilt
|
May be the tests itself need to be adjusted to work with phantomjs 2. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests are running fine with activesupport 5.2. Fixes #20