DBZ-8561 Correctly handle enum/set types in Vitess v20+ #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See this message for core logic used. We read this new flag that is set by newer vitess versions to indicate if the enum/set values are strings (previously only in snapshot, going forward is in snapshot & regular phase).
This makes Debezium forward compatible with Vitess upgrades to v20+ so we handle enum/set types correctly.
Without these changes, if debezium/debezium#6079 is merged then tests trivially fail. With these changes and that other PR then tests pass.
Right now, since the main upgrade isn't merged, tests trivially pass (does not use any of the new code)