Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing tests. #15

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Fix failing tests. #15

merged 1 commit into from
Oct 31, 2024

Conversation

ayalon
Copy link

@ayalon ayalon commented Oct 31, 2024

I have checked the test locally. The string is no longer available.

@ayalon ayalon mentioned this pull request Oct 31, 2024
Closed
rfay
rfay approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that line was removed in v1.23.5.

@ochorocho
Copy link
Collaborator

@ayalon thanks for the fix. LGTM.

@ochorocho ochorocho merged commit 7467dd7 into ddev:main Oct 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfay rfay rfay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ayalon @ochorocho @rfay