Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add OP normalizer #403

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Conversation

igorsimko
Copy link
Contributor

This PR adds support for Ophthalmic Photography 8 Bit Image modality. Often time referenced by OCT (#402)

Copy link

netlify bot commented Sep 18, 2024

Deploy Preview for dcmjs2 ready!

Name Link
🔨 Latest commit aefa305
🔍 Latest deploy log https://app.netlify.com/sites/dcmjs2/deploys/66fd4e2a59ec2700085234f2
😎 Deploy Preview https://deploy-preview-403--dcmjs2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@igorsimko
Copy link
Contributor Author

@pieper I went over OP normalizer again and I don't fully understand whether it's needed or not. Problem in this bug report refers to only OCT scan when trying to export segmentation for it. I haven't encountered segmentations for OP modality yet. Segmentations are usually only visualized on OP from OCT.

See following example where A is OCT and B is OP
image

OP file I attached (from realt device) doesn't have bunch of dicom tags which are used in normalizer.js so I would have to just use simple

class OPImageNormalizer extends Normalizer {
    normalize() {
        this.dataset = this.datasets[0];
    }
}

Do you think we should still add OP to normalizers in that case?

@pieper
Copy link
Collaborator

pieper commented Oct 2, 2024

I'm not familiar enough with OCT and OP to know for sure, but as a general design pattern for dcmjs it's good to have normalizers for any sop class so that code can rely on them providing a fixed up version of any non-standard dicom (e.g. fix up any vendor screwups). Many sop class normalizers can be basically no-ops, which is good.

@igorsimko
Copy link
Contributor Author

Thank you for you feedback. In that case I updated PR to also include test and run simple normalization as written in comment above.

Copy link
Collaborator

@sedghi sedghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, since test is passing i'm gonna merge it, great work

@sedghi sedghi merged commit 6840af9 into dcmjs-org:master Oct 29, 2024
13 checks passed
Copy link

🎉 This PR is included in version 0.35.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@igorsimko
Copy link
Contributor Author

@sedghi that's great to hear, thanks a lot! Shall we do same with #402?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants