-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add OP normalizer #403
Conversation
✅ Deploy Preview for dcmjs2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@pieper I went over OP normalizer again and I don't fully understand whether it's needed or not. Problem in this bug report refers to only OCT scan when trying to export segmentation for it. I haven't encountered segmentations for OP modality yet. Segmentations are usually only visualized on OP from OCT. See following example where A is OCT and B is OP OP file I attached (from realt device) doesn't have bunch of dicom tags which are used in
Do you think we should still add OP to normalizers in that case? |
I'm not familiar enough with OCT and OP to know for sure, but as a general design pattern for dcmjs it's good to have normalizers for any sop class so that code can rely on them providing a fixed up version of any non-standard dicom (e.g. fix up any vendor screwups). Many sop class normalizers can be basically no-ops, which is good. |
8d5e0cf
to
aefa305
Compare
Thank you for you feedback. In that case I updated PR to also include test and run simple normalization as written in comment above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, since test is passing i'm gonna merge it, great work
🎉 This PR is included in version 0.35.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This PR adds support for Ophthalmic Photography 8 Bit Image modality. Often time referenced by OCT (#402)