Add modify subcommand for editing dicom tags #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested with this example: dcmjs modify /Users/pieper/data/vhp/radiological/normalCT/c_vf2130.dcm --out /tmp/out.dcm --replace PatientAge=039Y; dcmjs dump /tmp/out.dcm | grep PatientAge
Test with a commandline like this: ``` python testscripts/walk.py ~/data/vhp/radiological/normalCT /tmp/outCT ``` Requires pydicom be already installed.
* Update to latest dcmjs to handle error listed below
* add `--logLevel` option to suppress warnings
* update walk.py testscript to use --logLevel option
```
C:\TelixTools\dcmjs-commands\node_modules\dcmjs\build\dcmjs.js:8419
if (isString) log.log(errmsg);else throw new Error(errmsg);
^
Error: Value exceeds max length, vr: CS, value: [object ArrayBuffer], length: undefined
at CodeString.writeBytes (C:\TelixTools\dcmjs-commands\node_modules\dcmjs\build\dcmjs.js:8419:53)
at CodeString.writeBytes (C:\TelixTools\dcmjs-commands\node_modules\dcmjs\build\dcmjs.js:8496:94)
at Tag.write (C:\TelixTools\dcmjs-commands\node_modules\dcmjs\build\dcmjs.js:8083:27)
at C:\TelixTools\dcmjs-commands\node_modules\dcmjs\build\dcmjs.js:10170:25
at Array.forEach (<anonymous>)
at Function.write (C:\TelixTools\dcmjs-commands\node_modules\dcmjs\build\dcmjs.js:10165:19)
at DicomDict.write (C:\TelixTools\dcmjs-commands\node_modules\dcmjs\build\dcmjs.js:10310:21)
at writeDicom (file:///C:/TelixTools/dcmjs-commands/src/index.js:15:33)
at Command.<anonymous> (file:///C:/TelixTools/dcmjs-commands/bin/dcmjs.js:43:5)
at Command.listener [as _actionHandler] (C:\TelixTools\dcmjs-commands\node_modules\commander\lib\command.js:542:17)
Node.js v18.19.0
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work-in-progress effort to provide some useful utility functions.