Change Base64 for HEX encoding to survive URL encoding done by various API's #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was only able to authenticate with restream.io after patching with the code in this PR. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. Ran into the situation where a Base64 URL encoded state passed to an authorisation endpoint (e.g Netatmo's API) came back partly decoded i.e
%2Bcame back as+- which is part of the standard Base64 charset. This is further decoded when comparing the initial state with the passed back state so+becomes%20,+is an alternative way to URL encode space) which then fails the comparison andoauth2-clifails with an invalid state error.This PR changes the Base64 encoding for HEX encoding which is better suited to survive across URL's passed back and forth and silly things done by some service API's. Since this is basically a random string, the encoding doesn't really matter than much for as long as it doesn't cause issues.